Add esbuild transpiler #62
Conversation
dzbarsky
force-pushed
the
esbuild_transpiler
branch
from
9f56eb8 to
e23be68
Compare
| **kwargs | ||
| ) | ||
|
|
||
| esbuild_transpiler = rule( |
There was a problem hiding this comment.
Lets create a macro here similar to the swc one to hide things like js_outs etc: https://github.com/aspect-build/rules_swc/blob/785f94c2bf39d3ddac4cbfd9d7786f6067209f77/swc/defs.bzl
| if ctx.outputs.map_outs: | ||
| action_outputs.append(ctx.outputs.map_outs[i]) | ||
|
|
||
| ctx.actions.run( |
There was a problem hiding this comment.
Lets add a mnemonic and progress message, see swc
|
I think we need things such as:
|
|
There has not been much activity on this PR. For now, we will convert it to a draft. Please mark as ready for review when you are ready to proceed. |
|
I think this was fixed in #98 |
|
@alexeagle I think there's additional glue needed to plug esbuild into |
|
I see, would you like to push this one forward then? |
|
Yeah, I have the macro bit Jason mentioned done now, I'll polish it a bit and submit |
|
sorry @dzbarsky looks like we made it "possible enough" and probably we'd try OXC if we made a fresh pass at other transpilers |
No worries. The reality is if anyone wants to actually use esbuild they need to apply patches to prevent sandbox escapes. The plugin approach is untenably slow. It matters more for bundling than transpiring but may as well have a single binary. Anyway my point is there are other challenges to doing this correctly so a missing macro is not the blocker for someone who wants to pursue it, they will need to dig in. |
6 participants
No description provided.